iBet uBet web content aggregator. Adding the entire web to your favor.
iBet uBet web content aggregator. Adding the entire web to your favor.



Link to original content: https://phabricator.wikimedia.org/T337354
⚓ T337354 Revisit the type of Z516's 'argument' key
Page MenuHomePhabricator

Revisit the type of Z516's 'argument' key
Closed, ResolvedPublic

Description

Description

Concerns have been raised about Z18 as the type of Z516's 'argument' key; in particular, an instance of Z18 can be resolved, whereas we wouldn't want resolution to happen inside an error object.

Based on comments in this merge request and also a recent voice conversation, Z39 appears to be a good candidate for the type of this key. Z516 is only used in a few places, and changing the type of this key from Z18 to Z39 should require only a smallish effort. Z516 has no uses in WikiLambda and none in function-evaluator.

Note that Z511 and Z526 both use keys of type Z39 to refer to other arbitrary keys, similarly to how Z516's 'argument' key is used.

Desired behavior/Acceptance criteria (returned value, expected error, performance expectations, etc.)

  • All tests involving Z516 should continue to work (after being modified appropriately).

Completion checklist

Event Timeline

DMartin-WMF renamed this task from Z516 to Revisit the type of Z516's 'argument' key.May 24 2023, 1:20 AM
DMartin-WMF updated the task description. (Show Details)

After AW team discussion on slack and in Engineering meeting, we decided to proceed with the change to Z39.

Change 924598 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (9abc7c2)

https://gerrit.wikimedia.org/r/924598

Change 924598 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (9abc7c2)

https://gerrit.wikimedia.org/r/924598