Allow inline editing of gallery captions and gallery image captions, in the same manner as we allow editing image captions.
Description
Details
Subject | Repo | Branch | Lines +/- | |
---|---|---|---|---|
Gallery: Make ve.ce.Gallery(Image)CaptionNode active (editable) | mediawiki/extensions/VisualEditor | master | +47 -4 |
Status | Subtype | Assigned | Task | ||
---|---|---|---|---|---|
Resolved | EAkinloose | T190224 Allow inline editing of gallery captions and gallery image captions | |||
Resolved | matmarex | T149602 Allow rich text editing of image captions in gallery dialog | |||
Resolved | matmarex | T150621 Update gallery dialog to work with Parsoid's native <gallery> implementation | |||
Resolved | Arlolra | T110910 Implement <gallery> extension natively inside Parsoid | |||
Resolved | Arlolra | T55874 Add a generic extension registration mechanism | |||
Resolved | Arlolra | T329662 Edited gallery captions are ignored unless gallery's data-mw is dropped |
Event Timeline
The problem here is probably going to be not the inline editing, but rather preventing the user from entering funny stuff into the gallery captions, like tables or other galleries. @Esanders says we don't really have a way to do that, but he might be working on one?
We enabled caption editing for block image captions without disabling adding lists (which aren't supported by Parsoid) and it hasn't seemed to be a problem. In an ideal world VE would prevent this, or Parsoid/wikitext would be able to handle it, but it seems to be rare enough that I don't think it needs to be a blocker.
Change 888313 had a related patch set uploaded (by Esanders; author: Esanders):
[mediawiki/extensions/VisualEditor@master] Gallery: Make ve.ce.Gallery(Image)CaptionNode active (editable)
Test wiki created on Patch demo by ESanders (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/bd25812a96/wiki/Gallery?veaction=edit
Test wiki on Patch demo by ESanders (WMF) using patch(es) linked to this task was deleted:
Change 888313 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Gallery: Make ve.ce.Gallery(Image)CaptionNode active (editable)
Thanks for adding to Tech News!
IIUC from this comment above: "ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.3; 2023-04-03)."
the feature will be riding the deployment train next week.
Hence I've moved it in Tech News into the "Changes this week" section.
Please let me know if I'm wrong, or bump it into next week's edition if that's needed.