iBet uBet web content aggregator. Adding the entire web to your favor.
iBet uBet web content aggregator. Adding the entire web to your favor.



Link to original content: https://github.com/ultralytics/yolov5/pull/1021
mosaic4 bottom left image fix by haoyuefan · Pull Request #1021 · ultralytics/yolov5 · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mosaic4 bottom left image fix #1021

Merged
merged 1 commit into from
Sep 23, 2020
Merged

mosaic4 bottom left image fix #1021

merged 1 commit into from
Sep 23, 2020

Conversation

haoyuefan
Copy link
Contributor

@haoyuefan haoyuefan commented Sep 23, 2020

fix a bug in load_mosaic

🛠️ PR Summary

Made with ❤️ by Ultralytics Actions

🌟 Summary

Improved image stitching for data augmentation in YOLOv5.

📊 Key Changes

  • Adjusted the calculation when stitching images together in the bottom left mosaic quadrant.

🎯 Purpose & Impact

  • 🎨 Purpose: This change ensures that when images are combined to create a mosaic for training the YOLOv5 model, the bottom left image is correctly positioned without any overlap or gap.
  • Impact: The potential impact is an increase in the accuracy of the YOLOv5 model by using better-formed training data, leading to improved performance in object detection tasks.

fix a bug in load_mosaic
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @yuefanhao, thank you for submitting a PR! To allow your work to be integrated as seamlessly as possible, we advise you to:

  • Verify your PR is up-to-date with origin/master. If your PR is behind origin/master update by running the following, replacing 'feature' with the name of your local branch:
git remote add upstream https://github.com/ultralytics/yolov5.git
git fetch upstream
git checkout feature  # <----- replace 'feature' with local branch name
git rebase upstream/master
git push -u origin -f
  • Verify all Continuous Integration (CI) checks are passing.
  • Reduce changes to the absolute minimum required for your bug fix or feature addition. "It is not daily increase but daily decrease, hack away the unessential. The closer to the source, the less wastage there is." -Bruce Lee

@glenn-jocher
Copy link
Member

@yuefanhao yes I think you are right, this change to the bottom left x coordinates would match the values used for the top left x coordinates.

Did you see any actual incorrect training images before this fix?

@glenn-jocher glenn-jocher changed the title Update datasets.py mosaic4 bottom left image fix Sep 23, 2020
@glenn-jocher glenn-jocher merged commit 7220cee into ultralytics:master Sep 23, 2020
burglarhobbit pushed a commit to burglarhobbit/yolov5 that referenced this pull request Jan 1, 2021
KMint1819 pushed a commit to KMint1819/yolov5 that referenced this pull request May 12, 2021
BjarneKuehl pushed a commit to fhkiel-mlaip/yolov5 that referenced this pull request Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants