[FrameworkBundle] Fix default PHP attributes support in validation and serializer configuration when doctrine/annotations is not installed with PHP 8 #44110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d serializer configuration when doctrine/annotations is not installed with PHP 8
fancyweb
commented
Nov 17, 2021
| @@ -942,8 +942,8 @@ private function addValidationSection(ArrayNodeDefinition $rootNode, callable $e | |||
|
|
|||
| private function addAnnotationsSection(ArrayNodeDefinition $rootNode, callable $willBeAvailable) | |||
| { | |||
| $doctrineCache = $willBeAvailable('doctrine/cache', Cache::class, 'doctrine/annotation'); | |||
| $psr6Cache = $willBeAvailable('symfony/cache', PsrCachedReader::class, 'doctrine/annotation'); | |||
| $doctrineCache = $willBeAvailable('doctrine/cache', Cache::class, 'doctrine/annotations'); | |||
There was a problem hiding this comment.
This is totally unrelated but that's surely a mistake?
There was a problem hiding this comment.
that's part of fixing the code, as doctrine/annotations is the right package name
nicolas-grekas
approved these changes
Nov 18, 2021
derrabus
approved these changes
Nov 18, 2021
|
Thank you @fancyweb. |
This was referenced Nov 18, 2021
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Afrer upgrading to PHP 8 and using real PHP attributes, I noticed there were no validation metadata for my classes anymore.
Before:
After:
I expect the migration to be transparent, ie not having to do any change in the config to switch from PHPDoc annotations to real PHP attributes. However,
validation.enable_annotationsdoes not default to true anymore after the migration so here is the fix. WDYT?