iBet uBet web content aggregator. Adding the entire web to your favor.
iBet uBet web content aggregator. Adding the entire web to your favor.



Link to original content: https://github.com/MobileTeleSystems/data-rentgen/pull/91
[DOP-20958] Add id fields to DTOs by dolfinus · Pull Request #91 · MobileTeleSystems/data-rentgen · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOP-20958] Add id fields to DTOs #91

Merged
merged 1 commit into from
Oct 25, 2024
Merged

[DOP-20958] Add id fields to DTOs #91

merged 1 commit into from
Oct 25, 2024

Conversation

dolfinus
Copy link
Member

@dolfinus dolfinus commented Oct 23, 2024 •
edited
Loading

Change Summary

  • Add id fields to almost all DTO classes
  • For RunDTO, OperationDTO, InputDTO, OutputDTO add fields with nested DTOs
  • Changes above allow to simplify code of consumer and repository methods like create_or_update - instead of passing DTO + a bunch of ids, just write id back to DTO, and pass to next repository method

Related issue number

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

@dolfinus dolfinus self-assigned this Oct 23, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 23, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 98.35165% with 3 lines in your changes missing coverage. Please review.

Project coverage is 91.69%. Comparing base (8e6bb24) to head (32c9990).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
data_rentgen/consumer/handlers.py 97.22% 0 Missing and 2 partials ⚠️
data_rentgen/consumer/extractors/operation.py 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop      #91      +/-   ##
===========================================
+ Coverage    91.52%   91.69%   +0.16%     
===========================================
  Files          152      151       -1     
  Lines         3046     3071      +25     
  Branches       215      217       +2     
===========================================
+ Hits          2788     2816      +28     
+ Misses         201      198       -3     
  Partials        57       57

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dolfinus dolfinus requested a review from TiGrib October 24, 2024 08:18
@dolfinus dolfinus marked this pull request as ready for review October 24, 2024 08:18
@dolfinus dolfinus merged commit a730050 into develop Oct 25, 2024
12 checks passed
@dolfinus dolfinus deleted the feature/DOP-20958 branch October 25, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TiGrib TiGrib TiGrib approved these changes

Assignees

@dolfinus dolfinus

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dolfinus @TiGrib