iBet uBet web content aggregator. Adding the entire web to your favor.
iBet uBet web content aggregator. Adding the entire web to your favor.



Link to original content: http://phabricator.wikimedia.org/T373676
⚓ T373676 Search results items have incorrect spacing in Persian Wikipedia
Page MenuHomePhabricator

Search results items have incorrect spacing in Persian Wikipedia
Closed, ResolvedPublicBUG REPORT

Description

This should be a recent thing. Related styles reach to Codex that's why I tagged Codex also.

Steps to replicate the issue (include links if applicable):
Open Persian Wikipedia in Persian interface
https://fa.wikipedia.org/?uselang=fa&useskin=vector-2022&safemode=1
Type 'a' in the search box

What happens?:

image.png (448×1 px, 55 KB)

What should have happened instead?:
Like Arabic Wikipedia (apparently locally patched? as the issues doesn't exist in their safemode=1)

https://ar.wikipedia.org/?uselang=fa&useskin=vector-2022

vs

https://ar.wikipedia.org/?uselang=fa&useskin=vector-2022&safemode=1

image.png (332×1 px, 37 KB)

Event Timeline

Restricted Application added subscribers: Huji, Aklapper. · View Herald Transcript

I was going to report the following separately but as far as I see this also comes from Codex so I will put it here, perhaps CSSJanus has failed on something?

Steps to replicate the issue (include links if applicable):
Open Persian Wikipedia, hide appearance menu then open it from above,

https://fa.wikipedia.org/?uselang=fa&useskin=vector-2022&safemode=1

What happens?:

image.png (922×434 px, 69 KB)

What should have happened instead?:
Like English counterpart,

image.png (972×602 px, 173 KB)

(Your attached images in the last comment are not visible to anyone else – please see instructions on how to fix that at https://www.mediawiki.org/wiki/Phabricator/Help#File_visibility)

FWIW, I see the issue described in your first comment at all three of the links provided. The icon has a margin-right on both LTR and RTL, when presumably it should be flipped to margin-left on RTL.

Codex has its own flipping implementation: https://gerrit.wikimedia.org/g/mediawiki/core/+/b5a1f97c2eee8dc47c5f20d63eaf6c263083e5af/includes/ResourceLoader/CodexModule.php#213 so this is probably best left for the team to debug.

Ebrahim attached a referenced file: F57355598: image.png. (Show Details)

Your attached images in the last comment are not visible to anyone else – please see instructions on how to fix that at

hopefully fixed

CCiufo-WMF moved this task from Inbox to Needs Refinement on the Design-System-Team board.
CCiufo-WMF subscribed.

Thanks for filing this -- we'll take a look at this next week.

Change #1069281 had a related patch set uploaded (by Catrope; author: Catrope):

[mediawiki/core@master] CodexModule: Fix double-flipping in RTL

https://gerrit.wikimedia.org/r/1069281

FWIW, I see the issue described in your first comment at all three of the links provided. The icon has a margin-right on both LTR and RTL, when presumably it should be flipped to margin-left on RTL.

Codex has its own flipping implementation: https://gerrit.wikimedia.org/g/mediawiki/core/+/b5a1f97c2eee8dc47c5f20d63eaf6c263083e5af/includes/ResourceLoader/CodexModule.php#213 so this is probably best left for the team to debug.

Thanks for this comment @matmarex, you linked to the exact line of code that contained the bug. We tweaked this logic recently as part of T314507, and while I tested this exact behavior during initial development, I forgot to test it again in the final patch that was merged.

Fixed in https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1069281

Test wiki created on Patch demo by EGardner (WMF) using patch(es) linked to this task:
http://patchdemo.wmcloud.org/wikis/e1d6327d54/w/

Change #1069281 merged by jenkins-bot:

[mediawiki/core@master] CodexModule: Fix double-flipping in RTL

https://gerrit.wikimedia.org/r/1069281

Change #1069310 had a related patch set uploaded (by Catrope; author: Catrope):

[mediawiki/core@wmf/1.43.0-wmf.20] CodexModule: Fix double-flipping in RTL

https://gerrit.wikimedia.org/r/1069310

Fix is scheduled for deployment on Monday September 2nd at 20:00 UTC.

Change #1069310 merged by jenkins-bot:

[mediawiki/core@wmf/1.43.0-wmf.20] CodexModule: Fix double-flipping in RTL

https://gerrit.wikimedia.org/r/1069310

Mentioned in SAL (#wikimedia-operations) [2024-09-02T20:51:12Z] <catrope@deploy1003> Started scap sync-world: Backport for [[gerrit:1069310|CodexModule: Fix double-flipping in RTL (T373676)]]

Mentioned in SAL (#wikimedia-operations) [2024-09-02T20:55:34Z] <catrope@deploy1003> catrope: Backport for [[gerrit:1069310|CodexModule: Fix double-flipping in RTL (T373676)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-09-02T21:02:44Z] <catrope@deploy1003> Finished scap sync-world: Backport for [[gerrit:1069310|CodexModule: Fix double-flipping in RTL (T373676)]] (duration: 11m 31s)