[Bug] Mobile mediaviewer doesn't work on Group 0 and Group 1 wikis
Closed, ResolvedPublic0 Estimated Story PointsBUG REPORT
Actions

Assigned To

Authored By

	• nray
	Apr 27 2023, 6:18 PM

Description

Steps to reproduce

Visit https://it.m.wikipedia.org/wiki/Scleri
Click on an image

Expected results

User stays on the same page and the mobile media viewer opens

For example,

2023-04-27_12-07-49 (3).png (1×3 px, 1 MB)

Actual results

The user is navigated to a different page that displays the image:

Environments observed

Browser version: Chrome 112
OS version: Mac OS Ventura
Device model: MacBook Pro
Device language: en

Check any additional observations

Observed on Vector desktop skin
Observed on MinervaNeue responsive skin
Observed while logged in
Observed while not logged in (anonymous)

Developer Notes

Note that this works on group 2 wikis, but not on group 0 or group 1. I believe this is related to the wgParserEnableLegacyMediaDOM config flag being set to false on group 0 and group 1.

QA Results - Prod

AC	Status	Details
1	✅	T335527#8829745 T335527#8833869

Details

	Subject	Repo	Branch	Lines +/-
	Fix mobile mediaviewer for when !wgParserEnableLegacyMediaDOM	mediawiki/extensions/MobileFrontend	master	+4 -4

Customize query in gerrit

Event Timeline

• nray triaged this task as High priority.Apr 27 2023, 6:18 PM

• nray created this task.

Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald TranscriptApr 27 2023, 6:18 PM

Arlolra claimed this task.Apr 27 2023, 6:24 PM

Arlolra edited projects, added Content-Transform-Team-WIP, Parsoid-Read-Views (Phase 0 - Parsoid-Media-Structure); removed Content-Transform-Team.

Restricted Application added a project: Parsoid. · View Herald TranscriptApr 27 2023, 6:24 PM

Moving to sprint 3 since this is only affecting group 1 and group 0 for now.

hey @Arlolra Just a note this is pretty urgent to fix from the web team side. We are assuming that fixing this would be a blocker for rolling out to group 2 wikis. We can support you if needed with code review as presumably this requires a change in MobileFrontend's JavaScript.

~~Also broken on desktop.~~ My mistake. Preference was disabled.

Jdlrobson removed a project: MediaViewer.Apr 27 2023, 6:41 PM

Arlolra moved this task from Backlog to In Progress on the Parsoid-Read-Views (Phase 0 - Parsoid-Media-Structure) board.Apr 27 2023, 7:01 PM

In T335527#8811672, @Jdlrobson wrote:

hey @Arlolra Just a note this is pretty urgent to fix from the web team side. We are assuming that fixing this would be a blocker for rolling out to group 2 wikis. We can support you if needed with code review as presumably this requires a change in MobileFrontend's JavaScript.

I'm working on a fix for it now and I will add you as reviewer. And yes, I consider it a blocker to further rolling out the config change.

~~Also broken on desktop.~~ My mistake. Preference was disabled.

Yeah, that was handled some time ago,
https://github.com/wikimedia/mediawiki-extensions-MultimediaViewer/commit/ae5a7aeac1f2c1a1b6bc932f1158afd9dca92da3

Change 912971 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/extensions/MobileFrontend@master] Fix mobile mediaviewer for when !wgParserEnableLegacyMediaDOM

https://gerrit.wikimedia.org/r/912971

gerritbot added a project: Patch-For-Review.Apr 27 2023, 8:36 PM

Arlolra moved this task from Backlog to Code Review on the Content-Transform-Team-WIP board.Apr 27 2023, 9:25 PM

Arlolra moved this task from In Progress to Code Review on the Parsoid-Read-Views (Phase 0 - Parsoid-Media-Structure) board.

Change 912971 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] Fix mobile mediaviewer for when !wgParserEnableLegacyMediaDOM

https://gerrit.wikimedia.org/r/912971

Arlolra moved this task from Code Review to To Deploy on the Content-Transform-Team-WIP board.Apr 27 2023, 9:47 PM

Arlolra moved this task from Code Review to To Deploy on the Parsoid-Read-Views (Phase 0 - Parsoid-Media-Structure) board.

Maintenance_bot removed a project: Patch-For-Review.Apr 27 2023, 10:11 PM

On a more general note would it help if web team audited their projects for any specific problems with the parsoid migration? We did something similar for IP masking and that may be useful here (I imagine section collapsing will need a rewrite for example)

Jdlrobson awarded a token.Apr 27 2023, 11:27 PM

MSantos removed a project: Parsoid.May 4 2023, 2:17 PM

LGoto moved this task from Incoming to QA in Production on the Web-Team-Backlog (Web Team FY2022-23 Q4 Sprint 3) board.May 4 2023, 5:39 PM

Jdlrobson edited projects, added Web-Team-Backlog (Web Team FY2022-23 Q4 Sprint 2); removed Web-Team-Backlog (Web Team FY2022-23 Q4 Sprint 3).May 4 2023, 5:39 PM

Jdlrobson added a project: Unplanned-Sprint-Work.

Jdlrobson set the point value for this task to 0.

Jdlrobson moved this task from Incoming to QA in Production on the Web-Team-Backlog (Web Team FY2022-23 Q4 Sprint 2) board.

Test Result - Prod

Status: ❓
Environment: itwiki
OS: macOS Ventura
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

Visit https://it.m.wikipedia.org/wiki/Scleri
Click on an image
❓ AC1: User stays on the same page and the mobile media viewer opens
@Jdlrobson, Not sure what I should be validating. When I click on the first image, the mobile viewer opens.

Screen Recording 2023-05-05 at 8.01.33 AM.mov.gif (1×1 px, 1 MB)

The second image opens a new page

Screen Recording 2023-05-05 at 8.03.26 AM.mov.gif (1×1 px, 935 KB)

@Arlolra this looks like it's still broken. It seems to only work for images in the lead section. Mobilefrontend lazy loads images beyond the lead section so presumably MobileFrontend needs to take into account the lazy markup.

In T335527#8830403, @Jdlrobson wrote:

@Arlolra this looks like it's still broken. It seems to only work for images in the lead section. Mobilefrontend lazy loads images beyond the lead section so presumably MobileFrontend needs to take into account the lazy markup.

Sorry, I'll get this fixed up today. Thanks for the QA

@Jdlrobson Sorry, no, this doesn't have anything to do with lazy loading. The wikitext looks like,

The presence of the |link= media option means that when you click on the link, the browser should navigate to that page and not open the media viewer. If you look at the non-mobile view, https://it.wikipedia.org/wiki/Scleri, the behaviour is the same.

Oh wow. I didn't realize the media viewer could be disabled that way.

Can confirm what you are saying here.
Looks like https://it.m.wikipedia.org/wiki/Isole_dei_Principi works as we were expecting. Sorry for the false alarm!

Edtadros updated the task description. (Show Details)May 9 2023, 11:05 PM

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.9; 2023-05-15).May 16 2023, 12:02 AM

	F36976902: Screen Recording 2023-05-05 at 8.03.26 AM.mov.gif
	May 5 2023, 3:10 PM

	F36976899: Screen Recording 2023-05-05 at 8.01.33 AM.mov.gif
	May 5 2023, 3:10 PM

[Bug] Mobile mediaviewer doesn't work on Group 0 and Group 1 wikisClosed, ResolvedPublic0 Estimated Story PointsBUG REPORTActions