iBet uBet web content aggregator. Adding the entire web to your favor.
iBet uBet web content aggregator. Adding the entire web to your favor.



Link to original content: http://phabricator.wikimedia.org/T227879
⚓ T227879 Bug: Qunit tests should not be ignored
Page MenuHomePhabricator
Create Task
Maniphest T227879

Bug: Qunit tests should not be ignored
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

It looks like some Qunit tests are not being executed anymore as a result of changes to resource modules list introduced in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CentralNotice/+/512429 , specifically - the onResourceLoaderTestModules at CentralNoticeHooks.php:409 when searching for test files implies that module has a scripts property but with newly added packageFiles replacement this is not true anymore for ext.centralNotice.display and hence tests/qunit/subscribing/ext.centralNotice.display.tests.js and tests/qunit/subscribing/ext.centralNotice.display.chooser.tests.js are not being included into Qunit tests list, which could lead to false positive CI status.

Details

SubjectRepoBranchLines +/-
Fix and reorganize QUnit testsmediawiki/extensions/CentralNoticemaster+73 -96
Customize query in gerrit

Revisions and Commits

rECNO extension-CentralNotice
rECNOa512a28ab6a6 ext.centralNotice.display: Convert to using packageFiles

Event Timeline

Vedmaka created this task.Jul 12 2019, 12:25 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 12 2019, 12:25 PM
Vedmaka added a commit: rECNOa512a28ab6a6: ext.centralNotice.display: Convert to using packageFiles.Jul 12 2019, 12:25 PM
Vedmaka added subscribers: Jdforrester-WMF, AndyRussG.
AndyRussG added a project: Fundraising-Backlog.Jul 15 2019, 7:01 AM

Confirmed! (See https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-hhvm-docker/58622/consoleFull)

Thanks for findning this!!

• DStrine set the point value for this task to 2.Jul 15 2019, 7:36 PM
• DStrine moved this task from Triage to Sprint +1 on the Fundraising-Backlog board.
• DStrine moved this task from Sprint +1 to Current Sprint on the Fundraising-Backlog board.Jul 29 2019, 8:16 PM
• DStrine added a project: Fundraising Sprint Office  .
AndyRussG moved this task from Backlog to Doing on the Fundraising Sprint Office   board.Jul 30 2019, 7:36 PM
AndyRussG claimed this task.Jul 30 2019, 7:51 PM
AndyRussG changed the point value for this task from 2 to 1.
AndyRussG changed the point value for this task from 1 to 2.Jul 30 2019, 10:19 PM
AndyRussG moved this task from Doing to Backlog on the Fundraising Sprint Office   board.Jul 31 2019, 4:22 PM
AndyRussG moved this task from Backlog to Doing on the Fundraising Sprint Office   board.Aug 1 2019, 5:08 PM
• mepps renamed this task from Some of Qunit tests are ignored to Bug: Qunit tests should not be ignored.Aug 2 2019, 2:52 PM
gerritbot added a comment.Aug 4 2019, 6:26 AM

Change 527861 had a related patch set uploaded (by AndyRussG; owner: AndyRussG):
[mediawiki/extensions/CentralNotice@master] Fix and reorganize QUnit tests

https://gerrit.wikimedia.org/r/527861

gerritbot added a project: Patch-For-Review.Aug 4 2019, 6:26 AM
AndyRussG moved this task from Doing to Review on the Fundraising Sprint Office   board.Aug 4 2019, 6:26 AM
• DStrine added a project: Fundraising Sprint Princess Mongodb.Aug 6 2019, 9:08 PM
AndyRussG moved this task from Backlog to Deployed on the Fundraising Sprint Princess Mongodb board.Aug 8 2019, 4:35 PM
AndyRussG moved this task from Deployed to Review on the Fundraising Sprint Princess Mongodb board.
gerritbot added a comment.Aug 8 2019, 8:05 PM

Change 527861 merged by jenkins-bot:
[mediawiki/extensions/CentralNotice@master] Fix and reorganize QUnit tests

https://gerrit.wikimedia.org/r/527861

Maintenance_bot removed a project: Patch-For-Review.Aug 8 2019, 8:10 PM
Ejegg moved this task from Review to Pending Deployment on the Fundraising Sprint Princess Mongodb board.Aug 8 2019, 10:04 PM
AndyRussG moved this task from Pending Deployment to Deployed on the Fundraising Sprint Princess Mongodb board.Aug 20 2019, 7:40 PM
• DStrine closed this task as Resolved.Aug 20 2019, 8:02 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits