iBet uBet web content aggregator. Adding the entire web to your favor.
iBet uBet web content aggregator. Adding the entire web to your favor.



Link to original content: http://github.com/thoughtbot/appraisal/pull/246
Small coding style fixes by n-rodriguez · Pull Request #246 · thoughtbot/appraisal · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small coding style fixes #246

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

n-rodriguez
Copy link
Contributor

Thank you!

warn "Your current version of Bundler does not support parallel installation. Please " +
"upgrade Bundler to version >= 1.4.0, or invoke `appraisal` without `--jobs` option."
warn "Your current version of Bundler does not support parallel installation. Please " \
"upgrade Bundler to version >= 1.4.0, or invoke `appraisal` without `--jobs` option."
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Metrics/LineLength: Line is too long. [100/80]

@@ -161,8 +161,8 @@ def bundle_options(options)
if Utils.support_parallel_installation?
options_strings << "--jobs=#{jobs}"
else
warn "Your current version of Bundler does not support parallel installation. Please " +
"upgrade Bundler to version >= 1.4.0, or invoke `appraisal` without `--jobs` option."
warn "Your current version of Bundler does not support parallel installation. Please " \
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Metrics/LineLength: Line is too long. [98/80]

@@ -54,11 +54,11 @@ def strip_heredoc(string)
method_option "retry", type: :numeric, default: 1,
desc: "Retry network and git requests that have failed"
method_option "without", banner: "GROUP_NAMES",
desc: "A space-separated list of groups referencing gems to skip " +
"during installation. Bundler will remember this option."
desc: "A space-separated list of groups referencing gems to skip " \
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Layout/AlignHash: Align the elements of a hash literal if they span more than one line.

@@ -15,7 +15,7 @@ def to_s
if @options.empty?
"git #{Utils.prefix_path(@source).inspect} do\n#{indent(super)}\nend"
else
"git #{Utils.prefix_path(@source).inspect}, #{Utils.format_string(@options)} do\n" +
"git #{Utils.prefix_path(@source).inspect}, #{Utils.format_string(@options)} do\n" \
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Metrics/LineLength: Line is too long. [92/80]

@@ -15,7 +15,7 @@ def to_s
if @options.empty?
"path #{Utils.prefix_path(@source).inspect} do\n#{indent(super)}\nend"
else
"path #{Utils.prefix_path(@source).inspect}, #{Utils.format_string(@options)} do\n" +
"path #{Utils.prefix_path(@source).inspect}, #{Utils.format_string(@options)} do\n" \
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Metrics/LineLength: Line is too long. [93/80]

warn "`rake appraisal:#{appraisal.name}` task is deprecated and will be removed soon. " +
"Please use `appraisal #{appraisal.name} rake #{ARGV.join(' ')}`."
warn "`rake appraisal:#{appraisal.name}` task is deprecated and will be removed soon. " \
"Please use `appraisal #{appraisal.name} rake #{ARGV.join(' ')}`."
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Metrics/LineLength: Line is too long. [85/80]

@@ -35,8 +35,8 @@ def initialize
desc "DEPRECATED: Run the given task for appraisal #{appraisal.name}"
task appraisal.name do
ARGV.shift
warn "`rake appraisal:#{appraisal.name}` task is deprecated and will be removed soon. " +
"Please use `appraisal #{appraisal.name} rake #{ARGV.join(' ')}`."
warn "`rake appraisal:#{appraisal.name}` task is deprecated and will be removed soon. " \
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Metrics/LineLength: Line is too long. [103/80]

exec "bundle exec appraisal install"
end

desc "DEPRECATED: Remove all generated gemfiles from gemfiles/ folder"
task :cleanup do
warn "`rake appraisal:cleanup` task is deprecated and will be removed soon. " +
"Please use `appraisal clean`."
warn "`rake appraisal:cleanup` task is deprecated and will be removed soon. " \
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Metrics/LineLength: Line is too long. [89/80]

exec "bundle exec appraisal generate"
end

desc "DEPRECATED: Resolve and install dependencies for each appraisal"
task :install do
warn "`rake appraisal:install` task is deprecated and will be removed soon. " +
"Please use `appraisal install`."
warn "`rake appraisal:install` task is deprecated and will be removed soon. " \
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Metrics/LineLength: Line is too long. [89/80]

@@ -11,22 +11,22 @@ def initialize
namespace :appraisal do
desc "DEPRECATED: Generate a Gemfile for each appraisal"
task :gemfiles do
warn "`rake appraisal:gemfile` task is deprecated and will be removed soon. " +
"Please use `appraisal generate`."
warn "`rake appraisal:gemfile` task is deprecated and will be removed soon. " \
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Metrics/LineLength: Line is too long. [89/80]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant