iBet uBet web content aggregator. Adding the entire web to your favor.
iBet uBet web content aggregator. Adding the entire web to your favor.



Link to original content: http://github.com/appwrite/appwrite/pull/8896
Fix 2365 Oauth2 does not add port number to uri by AryanSwaroop · Pull Request #8896 · appwrite/appwrite · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 2365 Oauth2 does not add port number to uri #8896

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

AryanSwaroop
Copy link

@AryanSwaroop AryanSwaroop commented Oct 29, 2024

What does this PR do?

This pr if detects a port then adds the port number to the redirrect uri's so it wouldn't cause any mismatch when using third party services like google auth. Previously , uri was only localhost but after this it will be localhost:8080.

In this video redirrect URI is localhost:8080 i.e. appwrite panel

Video_241103134712.mp4

Test Plan

  1. Previously , it was showing uri mismatch and error while using google OAuth.
  2. After changing the code , it redirects to success link without any problem.

Related PRs and Issues

Checklist

  • [ yes ] Have you read the Contributing Guidelines on issues?
  • [ yes ] If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant