iBet uBet web content aggregator. Adding the entire web to your favor.
iBet uBet web content aggregator. Adding the entire web to your favor.



Link to original content: http://github.com/Revolutionary-Games/Thrive/pull/5160
Hardcore mode by CI09 · Pull Request #5160 · Revolutionary-Games/Thrive · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hardcore mode #5160

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Hardcore mode #5160

wants to merge 9 commits into from

Conversation

CI09
Copy link
Contributor

@CI09 CI09 commented May 27, 2024 •
edited
Loading

Brief Description of What This PR Does

This PR adds hardcore mode - removes standard saving from game together with quicksaves and in place of auto-saves a save is performed that writes into one save name selected upon save creation.

Related Issues

Progress Checklist

Note: before starting this checklist the PR should be marked as non-draft.

  • PR author has checked that this PR works as intended and doesn't
    break existing features:
    https://wiki.revolutionarygamesstudio.com/wiki/Testing_Checklist
    (this is important as to not waste the time of Thrive team
    members reviewing this PR)
  • Initial code review passed (this and further items should not be checked by the PR author)
  • Functionality is confirmed working by another person (see above checklist link)
  • Final code review is passed and code conforms to the
    styleguide.

Before merging all CI jobs should finish on this PR without errors, if
there are automatically detected style issues they should be fixed by
the PR author. Merging must follow our
styleguide.

@CI09 CI09 added the review label May 27, 2024
@CI09 CI09 requested review from a team May 27, 2024 14:52
@hhyyrylainen hhyyrylainen added this to the Release 0.6.7 milestone May 27, 2024
HexapodPhilosopher
HexapodPhilosopher reviewed May 27, 2024
View reviewed changes
Copy link
Contributor

@HexapodPhilosopher HexapodPhilosopher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No bugs found. It is lacking a save on returning to the main menu, though. I was able to revert a bit by using that.

@hhyyrylainen
Copy link
Member

I didn't check but this mode should also suppress the warning for exiting without saving as this should force the save when exiting so that warning is not incorrectly shown.

hhyyrylainen
hhyyrylainen requested changes May 31, 2024
View reviewed changes
Copy link
Member

@hhyyrylainen hhyyrylainen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs more bulletproofing against players exploiting the fact that the game doesn't save when exiting in this mode before I think this is a polished enough feature to include in the game.

@HexapodPhilosopher
Copy link
Contributor

Also, wouldn't it make sense to include the checkbox for this in the Difficulty settings, rather than Misc? It's where most people would look for it.

@hhyyrylainen
Copy link
Member

What's the current progress on this? Last I checked this was very brittle in terms of how well it saves and keeps the player from very easily cheating in the difficulty mode.

@CI09
Copy link
Contributor Author

CI09 commented Jul 22, 2024

I got stuck at saving upon leaving so help would be useful. It's not mandatory feature though so you know...

@hhyyrylainen
Copy link
Member

That's fine, I'll just take this off the list of PRs I need to review.

@hhyyrylainen hhyyrylainen removed this from the Release 0.6.8 milestone Jul 22, 2024
@github-actions GitHub Actions
Copy link

This PR has been inactive for a while and as such is being marked
stale. This PR will be automatically closed if this stays stale
for a while.

If this is still being worked on / will probably resume work at
some point please feel free to continue working on this and reopen
this in case this was already automatically closed.

@github-actions github-actions bot added the stale label Oct 21, 2024
@revolutionary-bot
Copy link

We are currently in feature freeze until the next release.
If your PR is not just a simple fix, then it may take until the release to get reviewed and merged.

@github-actions github-actions bot removed the stale label Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HexapodPhilosopher HexapodPhilosopher HexapodPhilosopher left review comments

@hhyyrylainen hhyyrylainen hhyyrylainen requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
review
Projects
Thrive Planning
Status: In progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CI09 @hhyyrylainen @HexapodPhilosopher @revolutionary-bot